fix(grpc): patch loadPackageDefinition #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
requested review from
bg451,
danielkhan,
iredelmeier,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
danielkhan
approved these changes
Oct 4, 2019
| ) { | ||
| const result = original.apply(this, arguments as never); | ||
| // Copied from exports.loadPackageDefintion(...) | ||
| for (const serviceFqn in packageDef) { |
There was a problem hiding this comment.
Would it make sense to create a private function to do the code inside this for loop? That could help simplify the overall _patchLoadPackageDefinition function
|
|
||
| shimmer.massWrap( | ||
| serviceClient.prototype, | ||
| methodList as never[], |
There was a problem hiding this comment.
Out of curiosity: what's the role of the cast to never here?
| ); | ||
| endSpan(); | ||
| // if an error was emitted, the span will be ended there | ||
| if (status.code === 0) { |
There was a problem hiding this comment.
Could you add a unit test for this?
|
Closing this since the change in patching is unnecessary if example is used outside of lerna #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
The internal files loader is not correctly patching the internal generic catch all
client.makeClientConstructor, so the 2 main ways of creating clients are patched instead.loadObjectis not patched. I've disabled the generic patch until #285 solves the internal patches not propagating to the module's usage of them.